Abacn commented on code in PR #29849:
URL: https://github.com/apache/beam/pull/29849#discussion_r1440735070
##########
sdks/python/apache_beam/typehints/schemas.py:
##########
@@ -529,7 +541,7 @@ def typing_from_runner_api(
return Any
else:
return LogicalType.from_runner_api(
- fieldtype_proto.logical_type).language_type()
+ fieldtype_proto.logical_type)._language_type()
Review Comment:
The usage for argument in LogicalType is mostly define some metadata, and
making the encoded stream more compact without the need to attach the metadata
of the complex type in every element's encoded stream.
For example, for Decimal the argument is (unit, precision). Then a Decimal
can be encoded with row bytes representing only the number, without scale
information. It can then be recovered to a language type Decimal having the
arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
