bsannicolas commented on code in PR #29849:
URL: https://github.com/apache/beam/pull/29849#discussion_r1439660592
##########
sdks/python/apache_beam/typehints/schemas_test.py:
##########
@@ -511,10 +580,8 @@ def assert_namedtuple_equivalent(self, actual, expected):
#for attr in dir(expected):
# self.assertEqual(getattr(actual, attr), getattr(expected, attr))
- @parameterized.expand([
- (fieldtype_proto, )
- for fieldtype_proto in get_test_beam_fieldtype_protos()
- ])
+ @parameterized.expand([(fieldtype_proto, ) for fieldtype_proto in
+ get_test_beam_fieldtype_protos_with_logical_types()])
Review Comment:
I defined it cumulatively:
```
def get_test_beam_fieldtype_protos_with_logical_types():
logical_types = ...
selected_schemas_with_logical_types = ...
return get_test_beam_fieldtype_protos(
) + selected_schemas_with_logical_types + logical_types
```
But I can make that change for clarity?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
