lostluck commented on code in PR #29900:
URL: https://github.com/apache/beam/pull/29900#discussion_r1449510411
##########
sdks/go/pkg/beam/runners/prism/internal/worker/bundle.go:
##########
@@ -132,23 +134,66 @@ func (b *B) ProcessOn(ctx context.Context, wk *W) <-chan
struct{} {
},
}
- // TODO: make batching decisions.
- dataBuf := bytes.Join(b.InputData, []byte{})
+ // TODO: make sending cap decisions, to reduce processing time overhead.
Review Comment:
English is a terrible language. Rewriting to
// TODO: make batching decisions on the maxium to send per elements
block, to reduce processing time overhead."cap per send",
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
