damondouglas commented on code in PR #29900:
URL: https://github.com/apache/beam/pull/29900#discussion_r1447732139
##########
sdks/go/pkg/beam/core/timers/timers.go:
##########
@@ -53,6 +53,7 @@ type TimerMap struct {
type timerConfig struct {
Tag string
+ HoldSet bool
Review Comment:
I would have chosen `isHoldSet`. Now it makes sense why below in the earlier
code `!tc.HoldTimestamp.ToTime().IsZero()` is the behavior equivalent of
`HoldSet` or `isHoldSet`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
