damondouglas commented on code in PR #29900:
URL: https://github.com/apache/beam/pull/29900#discussion_r1447735109
##########
sdks/go/pkg/beam/runners/prism/internal/engine/data.go:
##########
@@ -39,6 +39,8 @@ type TentativeData struct {
// state is a map from transformID + UserStateID, to window, to
userKey, to datavalues.
state map[LinkID]map[typex.Window]map[string]StateData
+ // timers is a map from transformID + UserStateID, to window, to
userKey, to datavalues.
Review Comment:
I vote for a new type i.e. `TimerKey` to distinguish. Perhaps just leave it
for a future PR. As an aside, and something for the future, `LinkID` inspires
the question, "A link of what does LinkID identify?"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
