TongruiLi commented on code in PR #29963:
URL: https://github.com/apache/beam/pull/29963#discussion_r1450841480
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcGetDataStream.java:
##########
@@ -171,7 +182,9 @@ public GlobalData requestGlobalData(GlobalDataRequest
request) {
}
@Override
- public void refreshActiveWork(Map<String, List<KeyedGetDataRequest>> active)
{
+ public void refreshActiveWork(
+ Map<String, List<KeyedGetDataRequest>> active,
+ Map<String, List<HeartbeatRequest>> heartbeats) {
long builderBytes = 0;
Review Comment:
Request will get rejected if both KeyedGetDataRequest and Heartbeat request
are present at the same time. If its easy, can we assert that only one map is
not empty here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
