acrites commented on code in PR #29963:
URL: https://github.com/apache/beam/pull/29963#discussion_r1456454292
##########
runners/google-cloud-dataflow-java/worker/windmill/src/main/proto/windmill.proto:
##########
@@ -784,6 +827,17 @@ message StreamingGetDataResponse {
repeated bytes serialized_response = 2;
// Remaining bytes field applies only to the last serialized_response
optional int64 remaining_bytes_for_response = 3;
+
+ // Work item fingerprints available only for complete items. So if
+ // remaining_bytes_for_response > 0 the size of farmhash_fingerprint array is
+ // one less than the size of serialized_response as the fingerprint for the
+ // last message is not yet available.
+ // Will not be populated when heartbeat_response is set.
+ repeated uint64 farmhash_fingerprint = 4;
Review Comment:
Sounds good. I'll just reserve 4 to be safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
