acrites commented on code in PR #29963:
URL: https://github.com/apache/beam/pull/29963#discussion_r1450884197
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingModeExecutionContext.java:
##########
@@ -150,9 +159,13 @@ public void start(
@Nullable Instant synchronizedProcessingTime,
WindmillStateReader stateReader,
SideInputStateFetcher sideInputStateFetcher,
- Windmill.WorkItemCommitRequest.Builder outputBuilder) {
+ Windmill.WorkItemCommitRequest.Builder outputBuilder,
+ @Nullable Supplier<Boolean> workFailed) {
this.key = key;
this.work = work;
+ if (workFailed != null) {
+ this.workIsFailed = workFailed;
+ }
Review Comment:
I'll set it back to the default one that always returns `Boolean.FALSE` in
that case. I think for all use cases, we either always supply a non-null
Supplier or a null one though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
