riteshghorse commented on code in PR #30001:
URL: https://github.com/apache/beam/pull/30001#discussion_r1455650821
##########
sdks/python/apache_beam/transforms/enrichment.py:
##########
@@ -54,6 +56,12 @@ def cross_join(left: Dict[str, Any], right: Dict[str, Any])
-> beam.Row:
if k not in left:
# Don't override the values in left.
left[k] = v
+ elif left[k] != v:
+ _LOGGER.warning(
+ '%s exists in the input row as well the row fetched '
+ 'from API but have different values. Using the input '
+ 'value, you can override this behavior by passing a '
+ 'custom `join_fn`.' % k)
Review Comment:
sounds good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
