scwhittle commented on code in PR #29963:
URL: https://github.com/apache/beam/pull/29963#discussion_r1462309525
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/Work.java:
##########
@@ -97,6 +98,10 @@ public void setState(State state) {
this.currentState = TimedState.create(state, now);
}
+ public void setFailed(boolean isFailed) {
Review Comment:
how about removing bool param, and having this just transition to
this.failed= True?
We could drop data possibly if we set failed, stopped processing, and then
cleared it and committed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
