acrites commented on code in PR #29963:
URL: https://github.com/apache/beam/pull/29963#discussion_r1462359174
##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/FakeWindmillServer.java:
##########
@@ -304,17 +319,41 @@ public Windmill.GlobalData
requestGlobalData(Windmill.GlobalDataRequest request)
}
@Override
- public void refreshActiveWork(Map<String, List<KeyedGetDataRequest>>
active) {
+ public void refreshActiveWork(
+ Map<String, List<HeartbeatRequest>> heartbeats, boolean
sendKeyedGetDataRequests) {
Windmill.GetDataRequest.Builder builder =
Windmill.GetDataRequest.newBuilder();
- for (Map.Entry<String, List<KeyedGetDataRequest>> entry :
active.entrySet()) {
- builder.addRequests(
- ComputationGetDataRequest.newBuilder()
- .setComputationId(entry.getKey())
- .addAllRequests(entry.getValue()));
+ if (sendKeyedGetDataRequests) {
+ for (Map.Entry<String, List<HeartbeatRequest>> entry :
heartbeats.entrySet()) {
Review Comment:
Good point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
