scwhittle commented on code in PR #29963:
URL: https://github.com/apache/beam/pull/29963#discussion_r1462969801
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcWindmillStreamFactory.java:
##########
@@ -162,7 +167,14 @@ public GetDataStream createGetDataStream(
getDataThrottleTimer,
jobHeader,
streamIdGenerator,
- streamingRpcBatchLimit);
+ streamingRpcBatchLimit,
+ sendKeyedGetDataRequests,
+ processHeartbeatResponses);
+ }
+
+ public GetDataStream createGetDataStream(
+ CloudWindmillServiceV1Alpha1Stub stub, ThrottleTimer
getDataThrottleTimer) {
+ return createGetDataStream(stub, getDataThrottleTimer, false, (response)
-> {});
Review Comment:
Fine for now, but let's remove this version since the other path (direct
path related and not yet used) should handle failed heartbeats as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
