ahmedabu98 commented on PR #29834: URL: https://github.com/apache/beam/pull/29834#issuecomment-1917393556
> What if instead they were in a single subdirectory (like with protos) I like this alternative more actually. I've made some changes to instead generate wrappers inside the `apache_beam.transforms._external_transforms` package. Inside there, each destination gets its own file (e.g. transforms with destination `apache_beam/io` will be written to `apache_beam/transforms/_external_transforms/io.py`). Then we can make these transforms available to the `apache_beam/io` package by importing everything from `_external_transforms/io.py`. @robertwb @tvalentyn let me know if this is what you had in mind > Having generated files in one directory would also require updating / maintaining only one __init__.py file to facilitate the imports. Yeah I'd rather do this manually because I'm wary about altering existing files with a script. > I actually also thought about it and hesitated to suggest only since it felt a bit late in the game to do so. Not too late! The feedback helps to get this in a good shape before we release it to users -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
