ahmedabu98 commented on code in PR #29834:
URL: https://github.com/apache/beam/pull/29834#discussion_r1474851171
##########
sdks/python/gen_xlang_wrappers.py:
##########
@@ -212,9 +179,60 @@ class name. This can be overriden by manually providing a
name.
f.write(
"# NOTE: This file is autogenerated and should "
"not be edited by hand.\n")
+ f.write(
+ "# Configs are generated based on the expansion service\n"
+ f"# configuration in {input_services.replace(PROJECT_ROOT, '')}.\n")
+ f.write("# Refer to sdks/python/gen_xlang_wrappers.py for more info.\n")
dt = datetime.datetime.now().date()
- f.write(f"# Last updated on: {dt}\n\n")
+ f.write(f"#\n# Last updated on: {dt}\n\n")
yaml.dump(transform_list, f)
+ logging.info("Successfully wrote transform configs to file: %s", output_file)
+
+
+def validate_sdks_destinations(sdk, dest, service, identifier=None):
Review Comment:
True all generated wrappers will live in the `_external_transforms` package,
but under that package we group wrappers based on the specified destination.
The purpose is to make importing to the destination package easier. For
example, wrappers with destination `apache_beam/io/gcp` will be generated to
`_external_transforms/io_gcp.py`. Then we can simply import everything from
there to `io/gcp/__init__.py`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
