ahmedabu98 commented on code in PR #29834:
URL: https://github.com/apache/beam/pull/29834#discussion_r1474852170
##########
sdks/python/apache_beam/transforms/external_transform_provider_test.py:
##########
@@ -407,7 +432,8 @@ def test_run_pipeline_with_script_generated_transform(self):
with open(self.service_config_path, 'w') as f:
yaml.dump([expansion_service_config], f)
- generate_transforms_config(self.service_config_path,
self.transform_config_path)
+ generate_transforms_config(
Review Comment:
Good catch, we don't need to generate it for this test.
We still need jinja/yapf to test if the script handles modifications to
name/destination properly (see `test_script_workflow_with_modified_transforms`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
