Abacn commented on code in PR #30218:
URL: https://github.com/apache/beam/pull/30218#discussion_r1480542584
##########
sdks/java/io/jms/src/test/java/org/apache/beam/sdk/io/jms/JmsIOIT.java:
##########
@@ -196,11 +204,18 @@ public void testPublishingThenReadingAll() throws
IOException {
MetricsReader metricsReader = new MetricsReader(readResult, NAMESPACE);
long actualRecords =
metricsReader.getCounterMetric(READ_ELEMENT_METRIC_NAME);
+ // TODO(yathu) resolve pending messages with direct runner. Due to direct
runner only finalize
Review Comment:
My fix indeed broke this integration test, and I convinced myself that the
cause is that the direct runner having outstanding checkpoint doesn't finalize,
holding active consumer, and leading to other consumers not receiving remaining
messages within the time of test. See Caveat 2 in the PR description for
detailed explanation.
For
> failing test that attempts to resolve pending messages
Actually, we already have such "failing test that attempts to resolve
pending messages": #30225 . it's also flaky on master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
