Abacn commented on PR #30218: URL: https://github.com/apache/beam/pull/30218#issuecomment-1930773853
> Overall design SGTM. It sounds like it would have a performance impact, but is still worth it. Do you know if the recreating a session has a performance impact that could matter? > > (of course anything is better than data loss) Yeah, this PR - Recreate session and consumer on every getCheckpointMark , which has performance cost However, it also - acknowlege single message in a session (per JMS specification this is suffice), which has performance improvement So as long as time_cost( create-close-session + create-close-consumer) comparable to N*time_cost( acknowlege a message ) , N is the number of message per checkpoint, it shouldn't have negative effect to the performance. Will do more testing of course. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
