Abacn commented on code in PR #30218:
URL: https://github.com/apache/beam/pull/30218#discussion_r1480718257
##########
sdks/java/io/jms/src/test/java/org/apache/beam/sdk/io/jms/JmsIOIT.java:
##########
@@ -140,12 +137,12 @@ public interface JmsIOITOptions extends
IOTestPipelineOptions, StreamingOptions
@Parameterized.Parameters(name = "with client class {3}")
public static Collection<Object[]> connectionFactories() {
- return Collections.singletonList(
+ return ImmutableList.of(
new Object[] {
"vm://localhost", 5672, "jms.sendAcksAsync=false",
ActiveMQConnectionFactory.class
});
// TODO(https://github.com/apache/beam/issues/26175) Test failure on
direct runner due to
- // JmsIO read on amqp slow on Jenkins.
+ // JmsIO read on amqp slow on CI (passed locally)
Review Comment:
turns out we still cannot un-ignore ampq case. It can pass consistently on
my machine, but it still fails on CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
