tvalentyn commented on code in PR #29834:
URL: https://github.com/apache/beam/pull/29834#discussion_r1480743936


##########
sdks/python/test-suites/xlang/build.gradle:
##########
@@ -67,12 +67,22 @@ def ioXlang = new CrossLanguageTask().tap {
 
 // This list should include all expansion service targets in 
sdks/python/standard_expansion_services.yaml
 def servicesToGenerateFrom = [ioExpansionPath, gcpExpansionPath]
+def lowestSupportedVersion = 
project.properties['cross_language_validates_py_versions'].split(',')[0]

Review Comment:
   let's add a variable, so that you don't have to parse xlang options. 
Example: 
https://github.com/apache/beam/blob/f08058ca75cf41cc535bab2e0f5cd6ef38c801ee/.github/actions/setup-default-test-properties/test-properties.json#L4
 .



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to