ahmedabu98 commented on code in PR #29834:
URL: https://github.com/apache/beam/pull/29834#discussion_r1480782455
##########
sdks/python/test-suites/xlang/build.gradle:
##########
@@ -67,12 +67,22 @@ def ioXlang = new CrossLanguageTask().tap {
// This list should include all expansion service targets in
sdks/python/standard_expansion_services.yaml
def servicesToGenerateFrom = [ioExpansionPath, gcpExpansionPath]
+def lowestSupportedVersion =
project.properties['cross_language_validates_py_versions'].split(',')[0]
Review Comment:
Ahh I missed that part (thought pyproject.toml deps also show up in
base_image_requirements)
I guess it's not worth the work to look it up and resolve for a version
within the bounds? I'll opt for hardcoding it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
