tvalentyn commented on code in PR #29834:
URL: https://github.com/apache/beam/pull/29834#discussion_r1480775490
##########
sdks/python/test-suites/xlang/build.gradle:
##########
@@ -67,12 +67,22 @@ def ioXlang = new CrossLanguageTask().tap {
// This list should include all expansion service targets in
sdks/python/standard_expansion_services.yaml
def servicesToGenerateFrom = [ioExpansionPath, gcpExpansionPath]
+def lowestSupportedVersion =
project.properties['cross_language_validates_py_versions'].split(',')[0]
Review Comment:
> It goes through Py38's base_image_requirements file and uses the same
Jinja dependency version. This way we're always installing the same version
used to build the SDK.
Oh. how will jinja make its way in base_image_requirements? If it's not part
of beam SDK dependencies, I think it won't be there. I suppose you cool look it
up from `pyproject.toml`, or hardcode the same versionspec in both places.
##########
sdks/python/test-suites/xlang/build.gradle:
##########
@@ -67,12 +67,22 @@ def ioXlang = new CrossLanguageTask().tap {
// This list should include all expansion service targets in
sdks/python/standard_expansion_services.yaml
def servicesToGenerateFrom = [ioExpansionPath, gcpExpansionPath]
+def lowestSupportedVersion =
project.properties['cross_language_validates_py_versions'].split(',')[0]
Review Comment:
> It goes through Py38's base_image_requirements file and uses the same
Jinja dependency version. This way we're always installing the same version
used to build the SDK.
Oh. how will jinja make its way in base_image_requirements? If it's not part
of beam SDK dependencies, I think it won't be there. I suppose you cool look it
up from `pyproject.toml`, or hardcode the same versionspec in both place
(requires syncing)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
