ahmedabu98 commented on code in PR #29834: URL: https://github.com/apache/beam/pull/29834#discussion_r1482179389
########## sdks/python/setup.py: ########## @@ -275,8 +274,8 @@ def get_portability_package_data(): # executes below. generate_protos_first() - # Generate wrappers - generate_external_transform_wrappers() + if 'sdist' in sys.argv: Review Comment: As discussed offline, we don't need this condition anymore. The root cause for this was incorrectly resolving the sdk directory path in `generate_external_transform_wrappers`, which would fail for some environments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
