Abacn commented on code in PR #30278:
URL: https://github.com/apache/beam/pull/30278#discussion_r1484887033
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/fn/data/BeamFnDataInboundObserverTest.java:
##########
@@ -146,10 +147,15 @@ public void
testCloseVisibleToAwaitCompletionCallerAndProducer() throws Exceptio
Arrays.asList(DataEndpoint.create(TRANSFORM_ID, CODER, (value) ->
{})),
Collections.emptyList());
+ AtomicBoolean isReady = new AtomicBoolean(false);
Future<?> future =
executor.submit(
() -> {
observer.accept(dataWith("ABC"));
+ synchronized (this) {
Review Comment:
If "this" object is used elsewhere for concurrent handing it could cause
conflict. Could just synchronized (isReady) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
