Abacn commented on code in PR #30278:
URL: https://github.com/apache/beam/pull/30278#discussion_r1485462646
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/fn/data/BeamFnDataInboundObserverTest.java:
##########
@@ -165,6 +171,11 @@ public void
testCloseVisibleToAwaitCompletionCallerAndProducer() throws Exceptio
Future<?> future2 =
executor.submit(
() -> {
+ synchronized (isReady) {
Review Comment:
sorry, actually this cannot be synchronized (either using this or isReady).
Because synchronized block will block other thread's same synchronized block.
Here it will wait for signal indefinitely and cause deadlock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
