shunping commented on code in PR #30278:
URL: https://github.com/apache/beam/pull/30278#discussion_r1485427862
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/util/UnboundedScheduledExecutorServiceTest.java:
##########
@@ -553,7 +553,7 @@ public void testThreadsAreAddedOnlyAsNeededWithContention()
throws Exception {
LOG.info("Created {} threads to execute at most 100 parallel tasks",
largestPool);
// Ideally we would never create more than 100, however with contention it
is still possible
// some extra threads will be created.
- assertTrue(largestPool <= 104);
+ assertTrue(largestPool <= 110);
Review Comment:
As the comment above the change says, there could be more than 100 threads
created in the `UnboundedScheduledExecutorService`. The previous threshold is
set to 104 but it causes some flakiness recently. I attempt to increase to a
little bit more to see if it can stop or at least reduce the chance of failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
