robertwb commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1498119280
########## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/FakeBeamFnStateClient.java: ########## @@ -174,6 +215,124 @@ public CompletableFuture<StateResponse> handle(StateRequest.Builder requestBuild response = StateResponse.newBuilder().setAppend(StateAppendResponse.getDefaultInstance()); break; + case ORDERED_LIST_GET: + { + long start = request.getOrderedListGet().getRange().getStart(); + long end = request.getOrderedListGet().getRange().getEnd(); + + KvCoder<Long, Integer> coder = KvCoder.of(VarLongCoder.of(), VarIntCoder.of()); + long sortKey = start; + int index = 0; + if (request.getOrderedListGet().getContinuationToken().size() > 0) { Review Comment: I'm just suggesting `String::isEmpty()` over `String::size() > 0`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org