robertwb commented on code in PR #30317:
URL: https://github.com/apache/beam/pull/30317#discussion_r1498139008
##########
model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto:
##########
@@ -1075,6 +1111,42 @@ message StateClearRequest {}
// A response to clear state.
message StateClearResponse {}
Review Comment:
I prefer being consistent. If we want to restructure things to break
everything out, we can have that discussion, but it doesn't seem a clear enough
win to break consistency. (If the range is in the ordered list state state key,
the existing Get/Append/Clear will work just fine, no need for optional fields.)
@kennknowles for your thoughts too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
