Abacn commented on code in PR #30485:
URL: https://github.com/apache/beam/pull/30485#discussion_r1511766909
##########
sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/JmsIO.java:
##########
@@ -225,6 +225,8 @@ public abstract static class Read<T> extends
PTransform<PBegin, PCollection<T>>
abstract Duration getCloseTimeout();
+ abstract @Nullable Duration getReceiveTimeout();
Review Comment:
I am thinking about making the default a non-null value (e.g. 100 ms) so
user does not need to configure this in every pipeline. However on the other
hand this would more-or-less change the default behavior if existing user
assumes low letency. @damondouglas what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
