Abacn commented on code in PR #30485:
URL: https://github.com/apache/beam/pull/30485#discussion_r1513252262
##########
sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/JmsIO.java:
##########
@@ -586,7 +605,13 @@ public boolean advance() throws IOException {
try {
Message message;
synchronized (this) {
- message = this.consumer.receiveNoWait();
+ if (currentMessage != null || receiveTimeoutMillis == 0L) {
Review Comment:
if receiveTimeoutMillis is present and there isn't a message, currentMessage
is always null, so it will go to receive with timeout, instead of
receiveNoWait, is this not desirable?
Do you mean receive with timeout or receiveNoWait will "hit server"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
