jlampek commented on code in PR #30485:
URL: https://github.com/apache/beam/pull/30485#discussion_r1513041451
##########
sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/JmsIO.java:
##########
@@ -586,7 +605,13 @@ public boolean advance() throws IOException {
try {
Message message;
synchronized (this) {
- message = this.consumer.receiveNoWait();
+ if (currentMessage != null || receiveTimeoutMillis == 0L) {
Review Comment:
If receiveTimeoutMillis is provided, is it possible to not perform the
"currentMessage" check?
Otherwise the logic appears to aggressively hit a server until it first gets
a message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
