m-trieu commented on code in PR #30425:
URL: https://github.com/apache/beam/pull/30425#discussion_r1518206137
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -468,10 +472,18 @@ private StreamingDataflowWorker(
public static StreamingDataflowWorker
fromOptions(DataflowWorkerHarnessOptions options) {
ConcurrentMap<String, ComputationState> computationMap = new
ConcurrentHashMap<>();
long clientId = clientIdGenerator.nextLong();
+ ChannelCache channelCache =
Review Comment:
Do we want to share the StubFactory between GrpcDispatcherClient and
StreamingEngineClient? If yes it might be a good idea to create it externally
and inject it into both objects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
