m-trieu commented on code in PR #30425:
URL: https://github.com/apache/beam/pull/30425#discussion_r1520986277


##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/stubs/IsolationChannel.java:
##########
@@ -44,7 +44,7 @@
  * that each active rpc has its own channel.
  */
 @Internal
-class IsolationChannel extends ManagedChannel {
+public class IsolationChannel extends ManagedChannel {

Review Comment:
   yea its used in GrpcWindmillServer and will be used in StreamingEngineClient 
when we eventually inject it.
   
   We could create a Factory class to create the ChannelCache?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to