Abacn commented on code in PR #30425:
URL: https://github.com/apache/beam/pull/30425#discussion_r1520401764
##########
runners/google-cloud-dataflow-java/worker/build.gradle:
##########
@@ -71,6 +71,10 @@ def excluded_dependencies = [
library.java.truth // Test only
]
+// For Java8+ and less than Java11, use versions 2.x.x.
+// For Java11+ use versions 3.x.x per https://github.com/ben-manes/caffeine.
+def caffeine_cache_version = project.javaVersion < "11" ? "2.9.3" : "3.1.8"
Review Comment:
This won't work for release. build.gradle is just a build script and
executed when build the artifact. The version string is resolved during compile
time, so the released dataflow-worker will always get 2.9.3 (because the
artifacts were compiled using single java version - java8 then publish to maven)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
