sclukas77 commented on a change in pull request #12498:
URL: https://github.com/apache/beam/pull/12498#discussion_r473184583
##########
File path: sdks/python/apache_beam/io/jdbc.py
##########
@@ -96,25 +98,37 @@
def default_io_expansion_service():
- return BeamJarExpansionService('sdks:java:io:expansion-service:shadowJar')
+ return BeamJarExpansionService(
+ ':sdks:java:extensions:schemaio-expansion-service:shadowJar')
-WriteToJdbcSchema = typing.NamedTuple(
- 'WriteToJdbcSchema',
+ReadFromWriteToJdbcSchema = typing.NamedTuple(
Review comment:
I agree it is a more concise way of calling it. I updated the name here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
