sclukas77 commented on a change in pull request #12498:
URL: https://github.com/apache/beam/pull/12498#discussion_r473186190
##########
File path: sdks/python/apache_beam/io/jdbc.py
##########
@@ -96,25 +98,37 @@
def default_io_expansion_service():
- return BeamJarExpansionService('sdks:java:io:expansion-service:shadowJar')
+ return BeamJarExpansionService(
+ ':sdks:java:extensions:schemaio-expansion-service:shadowJar')
-WriteToJdbcSchema = typing.NamedTuple(
- 'WriteToJdbcSchema',
+ReadFromWriteToJdbcSchema = typing.NamedTuple(
+ 'ReadFromWriteToJdbcSchema',
+ [
+ ('location', unicode),
+ ('config', bytes)
+ ],
+)
+
+Config = typing.NamedTuple(
+ 'Config',
[
('driver_class_name', unicode),
('jdbc_url', unicode),
('username', unicode),
('password', unicode),
('connection_properties', typing.Optional[unicode]),
('connection_init_sqls', typing.Optional[typing.List[unicode]]),
- ('statement', unicode),
+ ('write_statement', typing.Optional[unicode]),
+ ('read_query', typing.Optional[unicode]),
+ ('fetch_size', typing.Optional[int]),
+ ('output_parallelization', typing.Optional[bool]),
],
)
class WriteToJdbc(ExternalTransform):
- """A PTransform which writes Rows to the specified database via JDBC.
+ """A PTransform which writes Rows to the specified database via JDBC.
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
