chamikaramj commented on code in PR #30998:
URL: https://github.com/apache/beam/pull/30998#discussion_r1567865679
##########
sdks/java/io/kafka/upgrade/src/main/java/org/apache/beam/sdk/io/kafka/upgrade/KafkaIOTranslation.java:
##########
@@ -102,6 +102,7 @@ static class KafkaIOReadWithMetadataTranslator implements
TransformPayloadTransl
.addNullableByteArrayField("key_deserializer_provider")
.addNullableByteArrayField("value_deserializer_provider")
.addNullableByteArrayField("check_stop_reading_fn")
+ .addNullableLogicalTypeField("consumer_polling_timeout", new
NanosDuration())
Review Comment:
You can probably just copy what we do for `max_read_time` above.
Also, since this is a new property for the current Beam version. We have to
not use this field for older Beam versions and set appropriate defaults. For
example see here:
https://github.com/apache/beam/blob/1e89f834c8438b3c9b20e0de4aa7f5d126a1e172/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOTranslation.java#L326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
