xianhualiu commented on code in PR #30998:
URL: https://github.com/apache/beam/pull/30998#discussion_r1567904910
##########
sdks/java/io/kafka/upgrade/src/main/java/org/apache/beam/sdk/io/kafka/upgrade/KafkaIOTranslation.java:
##########
@@ -102,6 +102,7 @@ static class KafkaIOReadWithMetadataTranslator implements
TransformPayloadTransl
.addNullableByteArrayField("key_deserializer_provider")
.addNullableByteArrayField("value_deserializer_provider")
.addNullableByteArrayField("check_stop_reading_fn")
+ .addNullableLogicalTypeField("consumer_polling_timeout", new
NanosDuration())
Review Comment:
@chamikaramj The new config consumerPollingTimeout already has a default of
2 seconds. Is the logic similar to
[beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOTranslation.java](https://github.com/apache/beam/blob/1e89f834c8438b3c9b20e0de4aa7f5d126a1e172/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOTranslation.java#L326)
still necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
