chamikaramj commented on code in PR #30998:
URL: https://github.com/apache/beam/pull/30998#discussion_r1567906726
##########
sdks/java/io/kafka/upgrade/src/main/java/org/apache/beam/sdk/io/kafka/upgrade/KafkaIOTranslation.java:
##########
@@ -320,6 +324,12 @@ public Row toConfigRow(Read<?, ?> transform) {
transform =
transform.withMaxReadTime(org.joda.time.Duration.millis(maxReadTime.toMillis()));
}
+ Duration consumerPollingTimeout =
configRow.getValue("consumer_polling_timeout");
Review Comment:
Pls change to:
```
if (TransformUpgrader.compareVersions(updateCompatibilityBeamVersion,
"2.56.0") < 0) {
transform =
transform.withConsumerPollingTimeout(Duration.standardSeconds(2L)); // Current
default.
} else {
Duration consumerPollingTimeout =
configRow.getValue("consumer_polling_timeout");
if (consumerPollingTimeout != null) {
transform =
transform.withConsumerPollingTimeout(
org.joda.time.Duration.millis(consumerPollingTimeout.toMillis()));
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
