nielm commented on PR #31008:
URL: https://github.com/apache/beam/pull/31008#issuecomment-2063298826
Effectively we already have this at the RPC level
```java
/** Specifies the commit deadline. This is overridden if the
CommitRetrySettings is specified. */
public SpannerConfig withCommitDeadline(Duration commitDeadline) {
return
withCommitDeadline(ValueProvider.StaticValueProvider.of(commitDeadline));
}
/** Specifies the commit retry settings. Setting this overrides the
commit deadline. */
public SpannerConfig withCommitRetrySettings(RetrySettings
commitRetrySettings) {
return toBuilder().setCommitRetrySettings(commitRetrySettings).build();
}
```
Both of these allow the deadline for a commit to complete to be set (The
[default is
15s)](https://github.com/apache/beam/blame/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerConfig.java#L46C2-L48C35).
Setting the commit deadline to significantly longer increases the risk of
Spanner going into overload and pushing back against writes, which will reduce
the throughput of the pipeline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
