kberezin-nshl commented on PR #31008: URL: https://github.com/apache/beam/pull/31008#issuecomment-2070296481
@nielm I am sorry but this is a _completely different_ feature. Please read the documentation link I am referring to. It was released a couple of weeks ago and we are already using it in production (we had to fork `SpannerIO` to be able to do so) and it improved performance of our jobs which write millions of records to Spanner dramatically. Setting commit deadline does not affect performance of the writes at all, it just tells the client library how much time it can wait and retry the transaction, whereas setting a maximum commit delay may improve performance significantly if your app doesn't care much about the exact commit timing. Documentation quote: > If you have a latency tolerant application and want to optimize throughput, setting a longer commit delay time significantly improves throughput while incurring higher latency for each write. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
