kberezin-nshl commented on PR #31008: URL: https://github.com/apache/beam/pull/31008#issuecomment-2070566681
> can you add tests in the Write test code not the Read tests to verify that the parameter is correctly passed to writeAtLeastOnce() Ah, sure. No idea why I updated `Read` instead of `Write` 🤦 Done. > do you have any suggestion for a default value? I think by default we should just leave it out (as I implemented), because there is already a [documented default behavior](https://cloud.google.com/spanner/docs/throughput-optimized-writes#default-behavior) for this case: > If you don't set a commit delay time, Spanner might set a small delay for you if it thinks that will amortize the cost of your writes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
