Abacn commented on code in PR #31106:
URL: https://github.com/apache/beam/pull/31106#discussion_r1587789379
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiSinkFailedRowsIT.java:
##########
@@ -26,13 +26,15 @@
import com.google.api.services.bigquery.model.TableSchema;
import java.io.IOException;
import java.util.List;
+import javax.annotation.Nullable;
Review Comment:
we use checkframework nullable
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiLoads.java:
##########
@@ -52,16 +52,18 @@
/** This {@link PTransform} manages loads into BigQuery using the Storage API.
*/
public class StorageApiLoads<DestinationT, ElementT>
extends PTransform<PCollection<KV<DestinationT, ElementT>>, WriteResult> {
- final TupleTag<KV<DestinationT, StorageApiWritePayload>>
successfulConvertedRowsTag =
- new TupleTag<>("successfulRows");
+ final TupleTag<KV<DestinationT, KV<ElementT, StorageApiWritePayload>>>
Review Comment:
Here it changed PTransform output element type. Do we need some change in
BigQueryTranslation to preserve upgrade compatibility? cc: @chamikaramj
or is there plan to setup precommit test for bigquery pipeline upgrade? so
tests can auto detect this (like kafka upgrade project)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
