chamikaramj commented on code in PR #31106:
URL: https://github.com/apache/beam/pull/31106#discussion_r1590610612
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiLoads.java:
##########
@@ -52,16 +52,18 @@
/** This {@link PTransform} manages loads into BigQuery using the Storage API.
*/
public class StorageApiLoads<DestinationT, ElementT>
extends PTransform<PCollection<KV<DestinationT, ElementT>>, WriteResult> {
- final TupleTag<KV<DestinationT, StorageApiWritePayload>>
successfulConvertedRowsTag =
- new TupleTag<>("successfulRows");
+ final TupleTag<KV<DestinationT, KV<ElementT, StorageApiWritePayload>>>
Review Comment:
I think changing output element type and the coder here could break
streaming update compatibility in general.
Have you considered using the `updateCompatibilityVersion` option ?
https://github.com/apache/beam/blob/c531f898d6b3454761f78a2420df5424178fb002/sdks/java/core/src/main/java/org/apache/beam/sdk/options/StreamingOptions.java#L45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
