ahmedabu98 commented on code in PR #31106:
URL: https://github.com/apache/beam/pull/31106#discussion_r1591186536
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiConvertMessages.java:
##########
@@ -177,11 +189,16 @@ public void processElement(
messageConverter
.toMessage(element.getValue(), rowMutationInformation)
.withTimestamp(timestamp);
- o.get(successfulWritesTag).output(KV.of(element.getKey(), payload));
+ o.get(successfulWritesTag)
+ .output(KV.of(element.getKey(), KV.of(element.getValue(),
payload)));
Review Comment:
These changes will introduce some performance/memory costs and I'm wondering
if we can keep it limited to just this use-case.
Does it make sense to include the original element (`element.getValue()`)
only when the user specifies a `formatRecordOnFailureFunction`? Otherwise we
can keep it null for example since it will never be checked
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
