acrites commented on code in PR #31822:
URL: https://github.com/apache/beam/pull/31822#discussion_r1690444606
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/config/StreamingEngineComputationConfigFetcher.java:
##########
@@ -187,6 +194,18 @@ private static StreamingEnginePipelineConfig
createPipelineConfig(StreamingConfi
pipelineConfig.setMaxWorkItemCommitBytes(config.getMaxWorkItemCommitBytes().intValue());
}
+ if (shouldPerformOutputSizeChecks && config.getOperationalLimits() !=
null) {
Review Comment:
I was looking for some way to only enable this feature by experiment first.
`shouldPerformOutputSizeChecks` is passed in based on an experiment being set.
If you think that's overkill, then yeah, I can just remove that parameter
entirely. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
