acrites commented on code in PR #31822:
URL: https://github.com/apache/beam/pull/31822#discussion_r1696011421
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/config/StreamingEngineComputationConfigFetcher.java:
##########
@@ -187,6 +194,18 @@ private static StreamingEnginePipelineConfig
createPipelineConfig(StreamingConfi
pipelineConfig.setMaxWorkItemCommitBytes(config.getMaxWorkItemCommitBytes().intValue());
}
+ if (shouldPerformOutputSizeChecks && config.getOperationalLimits() !=
null) {
Review Comment:
Ok. I'll go ahead and add `shouldThrowException...` to OperationalLimits so
we can decide what we want to do anywhere we're actually checking the limits.
This should make cleanup easier when we decide to get rid of the experiment and
make it always-on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
