scwhittle commented on code in PR #31822:
URL: https://github.com/apache/beam/pull/31822#discussion_r1690476264
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/config/StreamingEngineComputationConfigFetcher.java:
##########
@@ -187,6 +194,18 @@ private static StreamingEnginePipelineConfig
createPipelineConfig(StreamingConfi
pipelineConfig.setMaxWorkItemCommitBytes(config.getMaxWorkItemCommitBytes().intValue());
}
+ if (shouldPerformOutputSizeChecks && config.getOperationalLimits() !=
null) {
Review Comment:
that sounds good, I misread this earlier and thought it was where we were
evaluating limits.
Do you want to just add the experiment usage in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
