Abacn commented on code in PR #32399:
URL: https://github.com/apache/beam/pull/32399#discussion_r1759137291
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/logicaltypes/OneOfType.java:
##########
@@ -103,12 +100,12 @@ public String getIdentifier() {
@Override
public FieldType getArgumentType() {
- return FieldType.BYTES;
+ return FieldType.row(oneOfSchema);
}
@Override
- public byte[] getArgument() {
Review Comment:
this looks like a breaking change. However I am not sure the implication,
good to involve others reviewer, possibly @robertwb ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
