robertwb commented on code in PR #32399:
URL: https://github.com/apache/beam/pull/32399#discussion_r1764218930
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/logicaltypes/OneOfType.java:
##########
@@ -103,12 +100,12 @@ public String getIdentifier() {
@Override
public FieldType getArgumentType() {
- return FieldType.BYTES;
+ return FieldType.row(oneOfSchema);
}
@Override
- public byte[] getArgument() {
Review Comment:
Good question.
First, let's separate this change out into its own PR, so we can get the
rest (which looks good) in.
I'm worried about what existing pipelines might break if we change this.
Does a (null?) Row eventually get serialized with its schema as proto bytes
anyway? We could look into explicitly using deterministic proto serialization
here as an improvement at least.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
