scwhittle commented on code in PR #32399:
URL: https://github.com/apache/beam/pull/32399#discussion_r1768658280
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/logicaltypes/OneOfType.java:
##########
@@ -103,12 +100,12 @@ public String getIdentifier() {
@Override
public FieldType getArgumentType() {
- return FieldType.BYTES;
+ return FieldType.row(oneOfSchema);
}
@Override
- public byte[] getArgument() {
Review Comment:
Some change of OneOf is needed because it's schema now has a uuid set and
thus doesn't compare equal.
However I changed to keep using serialized proto but to recursively remove
the UUID from the schema proto before serializing.
PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
